Skip to content

fix(experiments): repair dead qualitative-feedback links in experiment skills - #91281

Merged
trunk-io[bot] merged 2 commits into
masterfrom
posthog-self-driving/fixexperiments-remove-dead-qualitative-b07a95
Sep 1, 2026
Merged

trunk-io[bot] merged 2 commits into
masterfrom
posthog-self-driving/fixexperiments-remove-dead-qualitative-b07a95

Conversation

@posthog

@posthog posthog Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Problem

  • A reader following the qualitative-feedback handoff cannot open the promised file. The optional survey handoff is a dead end.
  • The link reads references/qualitative-feedback.md, which resolves relative to the skill doing the pointing — and none of those skills has a references/ directory.
  • The file exists, but under a sibling skill: diagnosing-experiment-results/references/qualitative-feedback.md.
  • Three skills carry the handoff, so a reader hits the same dead path from any of them.

Changes

  • Each handoff now points at a resolvable relative link, so the reader opens the file instead of hitting a dead path.
  • Mechanical: one line each in analyzing-experiment-session-replays, scanning-experiments-with-replay-vision, and managing-experiment-lifecycle; the [[diagnosing-experiment-results]] wiki-link stays for skill discovery.

How did you test this code?

  • Confirmed ../diagnosing-experiment-results/references/qualitative-feedback.md resolves to an existing file from each of the three skill directories.
  • Swept every skill in the repo for path references that do not resolve, to confirm no fourth occurrence of this handoff was missed.
  • No automated tests apply to a documentation link.

Automatic notifications

  • Publish to changelog?

Docs update

None.

🤖 Agent context

Autonomy: Fully autonomous

  • An earlier revision fixed only the reported skill and left the two siblings. They carried the identical dead path, so they are fixed here too rather than left for a follow-up.
  • The relative-link shape matches existing cross-skill references elsewhere in the repo, so this follows the established convention rather than introducing one.
  • The sweep also surfaced many cross-skill mentions written as prose that names the owning skill (`authoring-scouts` → `references/report-contract.md`). Those are a deliberate convention, not the same defect, and were left alone.
  • The handoff content is useful, so the fix repairs the link rather than removing the section.

Created with PostHog Desktop from this inbox report.

The analyzing-experiment-session-replays skill points readers to
`references/qualitative-feedback.md`, but the path resolves relative to
that skill, which has no references directory. The file lives under the
diagnosing-experiment-results skill. Rewrite the reference as a relative
link to the actual file so the handoff opens.

Generated-By: PostHog Desktop
Task-Id: 56e75e09-a7d2-4f81-84de-79cf34a17788
@trunk-io

trunk-io Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 CI report

⚠️ Trunk lane — backend Python lane

This PR is assigned to the backend Python lane. It runs backend Python tests and may merge in parallel with PRs in other lanes.

…wo sibling skills

The two remaining skills that point readers at the survey handoff carried the
same unresolvable path as the one already repaired. Both now use the relative
link to the file's owning skill, so the reader opens it instead of hitting a
dead path.

Generated-By: PostHog Desktop
Task-Id: 117555df-8e62-47e7-ba6a-7063f1859da5
@mp-hog mp-hog changed the title fix(experiments): repair dead qualitative-feedback link in replay skill fix(experiments): repair dead qualitative-feedback links in 3 experiment skills Sep 1, 2026
@mp-hog mp-hog changed the title fix(experiments): repair dead qualitative-feedback links in 3 experiment skills fix(experiments): repair dead qualitative-feedback links in experiment skills Sep 1, 2026
@mp-hog
mp-hog marked this pull request as ready for review September 1, 2026 19:32
@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team September 1, 2026 19:33
@mp-hog mp-hog added the stamphog Request AI approval (no full review) label Sep 1, 2026
@stamphog

stamphog Bot commented Sep 1, 2026

Copy link
Copy Markdown

stamphog does not review bot-authored pull requests, so the trigger label has been removed. This change needs a human reviewer.

@stamphog stamphog Bot removed the stamphog Request AI approval (no full review) label Sep 1, 2026
@mp-hog mp-hog self-assigned this Sep 1, 2026
@trunk-io
trunk-io Bot merged commit 3f6a11d into master Sep 1, 2026
337 of 345 checks passed
@trunk-io
trunk-io Bot deleted the posthog-self-driving/fixexperiments-remove-dead-qualitative-b07a95 branch September 1, 2026 20:29
@deployment-status-posthog

deployment-status-posthog Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-09-01 21:05 UTC Run
prod-us ✅ Deployed 2026-09-01 21:20 UTC Run
prod-eu ✅ Deployed 2026-09-01 21:21 UTC Run

dmarticus added a commit that referenced this pull request Sep 4, 2026
…t skills (#91281)

Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
Co-authored-by: Marcel Poelker <marcel@posthog.com>
dmarticus added a commit that referenced this pull request Sep 4, 2026
…t skills (#91281)

Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
Co-authored-by: Marcel Poelker <marcel@posthog.com>
dmarticus added a commit that referenced this pull request Sep 4, 2026
…t skills (#91281)

Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
Co-authored-by: Marcel Poelker <marcel@posthog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants